Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(bug) (wip) Bork's eval/bake breaks when there are arguments with whitespaces #13

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

skylarmacdonald
Copy link
Member

DO NOT MERGE.

From mattly:

So this is a stab at #5 whereby bake isn't handling quoted arguments well. And, I knew I was doing something hacky with bake, but I really had no idea just how hacky. Short of reworking all the types to turn bake ls -la $dir into bake "ls -la $dir", this seems to be the next best thing: escaping quotes on every item in the argument list to bake.

The problem is bake is so central to everything, all for the sake of having nice, stubbable tests, whereby I could test the logic for e.g. apt on my mac, or brew on a linux CI server, without resorting to VMs and whatnot. So now pretty much all of the tests are going to fail and need to have their respond_to and baking_output stuff changed.

Since I'm not even sure this will have the desired effect without breaking everything (it seems to work ok locally) I'd like to get some eyes on it before going to the effort of updating all the tests.

@skylarmacdonald skylarmacdonald added this to the v0.13.x milestone Feb 25, 2021
@skylarmacdonald skylarmacdonald added the bug Something isn't working label Feb 25, 2021
@skylarmacdonald skylarmacdonald modified the milestones: v0.13.x, v1.0.x Jul 31, 2021
@skylarmacdonald skylarmacdonald added the core Relates to core Bork code, not types or assertions label Aug 1, 2021
@skylarmacdonald skylarmacdonald linked an issue Mar 13, 2022 that may be closed by this pull request
@skylarmacdonald skylarmacdonald changed the title (bug) Bork's eval/bake breaks when there are arguments with whitespaces (bug) (wip) Bork's eval/bake breaks when there are arguments with whitespaces Mar 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working core Relates to core Bork code, not types or assertions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(bug) Whitespace issues
2 participants